Refactor candidate 2 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tankbusta
approved these changes
Apr 16, 2018
| cfds = False if winders else True | ||
| shl = False if winders else True | ||
| cflags = DETACHED_PROCESS if self.running_on_windows else 0 | ||
| cfds = False if self.running_on_windows else True |
There was a problem hiding this comment.
You don't have to change this but apparently this is also possible (I didn't know until now)
cfds = not self.running_on_windows
| def fmtCsumData(self, sep='/'): | ||
| if self._is_ip: | ||
| return '%s %s %s ' % (self.fmtL3Csums(), sep, self.fmtL4Csums()) | ||
| else: |
There was a problem hiding this comment.
This else can be removed
| if proto_name and ip and port: | ||
| return self._linux_find_sock_by_endpoint_unsafe(ipver, proto_name, | ||
| ip, port, local) | ||
| else: |
| except WindowsError as e: | ||
| if e.winerror in [4,6,995]: | ||
| if e.winerror in [4, 6, 995]: | ||
| return | ||
| else: |
|
Thanks for taking the time to look closely. In the interest of not further blocking progress on other tickets, I'm going to continue the merge, but I've added your comments to my file of code quality issues and am going to add a code quality project to my roadmap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified packet processing code for Windows and Linux