Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to install right click menu option for Windows #970

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

lyc8503
Copy link
Contributor

@lyc8503 lyc8503 commented Mar 14, 2024

This implements #745.

Implemented two options for installing and uninstalling the Windows context menu and tested them on Windows.

By the way, I've also added a hint to upgrade pip and setuptools in the documentation (PEP660 has only been implemented in newer versions of setuptools)

Copy link

google-cla bot commented Mar 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

floss/main.py Outdated Show resolved Hide resolved
doc/installation.md Show resolved Hide resolved
floss/utils.py Outdated Show resolved Hide resolved
@mr-tz
Copy link
Collaborator

mr-tz commented Mar 16, 2024

This looks great. I will test it next week and let you know if there's any other changes needed. Thank you very much!

floss/main.py Outdated Show resolved Hide resolved
floss/utils.py Outdated Show resolved Hide resolved
floss/utils.py Outdated Show resolved Hide resolved
floss/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much. I like this solution and if people have issues given the various installation methods, we can fix this.

Only thing left to do is a small entry in the documentation at https://github.com/mandiant/flare-floss/blob/master/doc/usage.md. Can you add this, please?

@lyc8503
Copy link
Contributor Author

lyc8503 commented Mar 21, 2024

Hi, I have updated the document, and thanks for your code review and feedback too. 😃

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks a lot!

@mr-tz mr-tz merged commit 01a0a69 into mandiant:master Mar 22, 2024
19 checks passed
This was referenced Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants