Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip issuer check in processIdToken if skipIssuerCheck is true #527

Merged
merged 3 commits into from Jul 17, 2019

Conversation

ismcagdas
Copy link
Contributor

Resolves #492

@Soren-Knudsen
Copy link

What is the status of this PR?

@karthikkgunasekaran
Copy link

We are in need of this fix to support multi-tenancy. We have Azure Active directory as a common identity system and the issuer varies based on the Azure Active directory (different organizations). We make issuer checks through application logic after the user has logged in.

@ismcagdas
Copy link
Contributor Author

We are also waiting for this PR to be merged and a new minor release after that. @jeroenheijmans It would be great if you have time for this and check the PR.

Copy link
Collaborator

@jeroenheijmans jeroenheijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sensible to me. 👍

Good thing a new major release is in the making, as this might impact existing users in ways we haven't anticipated.

@jeroenheijmans
Copy link
Collaborator

Might also fix #523, I believe?

@ismcagdas
Copy link
Contributor Author

Is there any progress on this ? Will be a 5.0.3 in the near future ?

Thanks.

@jeroenheijmans
Copy link
Collaborator

Status/progress is up to the maintainer, but either way I would not expect a 5.0.3 version (based on this): if this PR gets merged it'd probably go into a 8.x version.

@ismcagdas
Copy link
Contributor Author

Great to hear about version 8. With or without this PR, I hope to see this fix/enhancement in v8 😄. Thanks a lot for the information.

@jeroenheijmans
Copy link
Collaborator

Don't think the newest commit (9ca6b23) is appropriate. The upgrade of packages doesn't seem to belong in this PR, and the change of the package name certainly doesn't belong here (unless I'm missing something?).

@ismcagdas
Copy link
Contributor Author

@jeroenheijmans sorry it was a mistake, I have reverted the commit.

@manfredsteyer manfredsteyer merged commit b93e1ff into manfredsteyer:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skipIssuerCheck flag is ignored
5 participants