Only present the sendAccessToken interceptor mechanism in the Readme #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Firstly, thank you very much for this awesome library. At my company, we build a lot of Angular applications in an Openid Connect environment and this dependency is a must. Having helped some teams implementing it, when coming to the interceptor part, I discovered that most people use a classic http interceptor and use the first snippet of code for sending the access token.
This is sad because the feature you implemented in the 3.1 version is really great and this white listing mechanism is very convenient and improve the security. I think it deservers to be the only displayed implementation in the Readme, which should focus on a basic setup, and let the documentation display alternative ways, which it already does very well. Also, the 3.1 version has been out for a year and half now and all Angular 4+ projects can use this implementation.
The best would have been to display an https url but the provided url in the snippet display an SSL_ERROR_BAD_CERT_DOMAIN when going on https so I didn't make the change on this.
If you think the classic interceptor should be kept into the Readme, I can udpate my pull request and put it back at second.
I'm looking for any comment that you may think useful.
Kind regards