Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mangadig] download issue #6886

Closed
Xeiv opened this issue Mar 17, 2024 · 6 comments · Fixed by #7020
Closed

[Mangadig] download issue #6886

Xeiv opened this issue Mar 17, 2024 · 6 comments · Fixed by #7020
Labels
Can't reproduce bug For those bugs devs can't reproduce

Comments

@Xeiv
Copy link

Xeiv commented Mar 17, 2024

Did you read the troubleshooting guide
Yes

Describe the bug
When I download chapters sometimes I get
mjs/engine/Connector.mjs:618 Error: Failed to load "https://mangadig.com/manga-rg308526/1/11.html" within the given timeout of 30 seconds! at mjs/engine/Request.mjs:323 EventTarget _getPageList @ mjs/engine/Connector.mjs:618
or
TypeError: Cannot read property 'isDevToolsOpened' of null at MangaDig.mjs:3 at MangaDig._getPages (MangaDig.mjs:3) at MangaDig._getPageList (Connector.mjs:615) at Chapter.mjs:111 EventTarget

To Reproduce
Steps to reproduce the behavior:

  1. Go to Mangadig
  2. Click on any series
  3. Download Multiple chapters
  4. first few downloads fine but then the errors start

Expected behavior
Chapters get downloaded

Screenshots
image

Context (please complete the following information):

  • OS: Windows 11
  • HakuNeko Version 6.1.7

Additional context
The chapters work fine when I open it in my browser or new window in hakuneko

@Xeiv Xeiv added the Bug Flaw, Failure or Fault leading to incorrect or unexpected Results label Mar 17, 2024
@MikeZeDev
Copy link
Contributor

MikeZeDev commented Mar 17, 2024

I tested a couple of them, it works. I am sorry, we cant test "any serie". The point of having a manga and a chapter is to reproduce the bug more easily, just dont say "any serie", mention one pls.

Also.... Did you really try nightly (like you should because you checked the box).

HakuNeko Version 6.1.7

Cause its not nightly.

Try nightly if it doesnt work give us a specific MANGA and CHAPTER. Were you binge downloading? Maybe you were blocked temporarily by the website?

@MikeZeDev MikeZeDev added Can't reproduce bug For those bugs devs can't reproduce and removed Bug Flaw, Failure or Fault leading to incorrect or unexpected Results labels Mar 17, 2024
@MikeZeDev
Copy link
Contributor

Maybe related as Mangadig and Coco are the same #6862

@Xeiv
Copy link
Author

Xeiv commented Mar 17, 2024

I tested a couple of them, it works. I am sorry, we cant test "any serie".

If you were bulk downloading i'd maybe the website blocked you, idk.

Also.... Did you really try nightly?

HakuNeko Version 6.1.7

Cause its not nightly.

Try nightly if it doesnt work give us a specific MANGA and CHAPTER. Were you binge downloading? Maybe you were blocked temporarily by the website?

Same issue with the nightly, the series is Divine Coffin Spirit,
I was binge downloading so might have gotten temp blocked but the exact chapter does work on the website and the new window in hakuneko when I check right after it fails
It randomly happens when I don't binge download too

Maybe related as Mangadig and Coco are the same #6862

Yeah I think so, this might help with the issue

Also I keep getting these warnings Provided mime type "image/webp" does not match the file signature and Connector.mjs:717 was replaced by "image/jpeg"! but I don't think it's related

@Sheepux Sheepux changed the title [Bug] Mangadig download issue [Mangadig] download issue Mar 17, 2024
@MikeZeDev
Copy link
Contributor

MikeZeDev commented Mar 17, 2024

Also I keep getting these warnings Provided mime type "image/webp" does not match the file signature and Connector.mjs:717 was replaced by "image/jpeg"! but I don't think it's related

It just means server tell wrong image type so we correct it. Its unrelated.
I mean the error you got is usually when there is something wrong while loading the page itself and hard to diagnose.

Maybe, try replacing the content of your Mangadig.mjs by this?
https://raw.githubusercontent.com/manga-download/hakuneko/cf8fb350f5e512d44bb86bb6252de0305405e28a/src/web/mjs/connectors/MangaDig.mjs

Because i use nightly but i may still have the file from the mentioned fix, so ofc it works for me 🤷

@Xeiv
Copy link
Author

Xeiv commented Mar 17, 2024

It just means server tell wrong image type so we correct it. Its unrelated. I mean the error you got is usually when there is something wrong while loading the page itself and hard to diagnose.

Ah okay

Maybe, try replacing the content of your Mangadig.mjs by this? https://raw.githubusercontent.com/manga-download/hakuneko/cf8fb350f5e512d44bb86bb6252de0305405e28a/src/web/mjs/connectors/MangaDig.mjs

Because i use nightly but i may still have the file from the mentioned fix, so ofc it works for me 🤷

I think this fixed it but not sure, I haven't gotten any errors after replacing it though. Thank you 😁

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Mar 17, 2024

Please keep in mind next time haku update the file could be replaced by the old one. Fix is temporary so youll have do it again until it is officially available to the people.

MikeZeDev added a commit that referenced this issue Apr 24, 2024
Fixes #6886 ? 

relevant commit : manga-download/hakuneko-plugins@05bbb2e

Again, a one line commit for a nasty website :)

(Mangadig & Coco were tested)
MikeZeDev added a commit that referenced this issue Apr 24, 2024
Fixes #6886 ? 

relevant commit : manga-download/hakuneko-plugins@05bbb2e

Again, a one line commit for a nasty website :)

(Mangadig & Coco were tested)
serge-reboul pushed a commit to serge-reboul/hakuneko that referenced this issue Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can't reproduce bug For those bugs devs can't reproduce
Projects
None yet
2 participants