Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @testing-library/vue from 7.0.0 to 8.0.1 #126

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 4, 2023

Bumps @testing-library/vue from 7.0.0 to 8.0.1.

Release notes

Sourced from @​testing-library/vue's releases.

v8.0.1

8.0.1 (2023-11-20)

Bug Fixes

  • Revert Errors Regarding Missing Global Hooks (#310) (1bbeeb4)

v8.0.0

8.0.0 (2023-10-31)

bug

  • Fix issue on Vite env not cleaning up after test (#297) (88fb8cd)

BREAKING CHANGES

  • This PR change default behavior for Vitest users. This major should yield no effect to other test frameworks.

Throw error when running vitest with no afterEach global and no VTL_SKIP_AUTO_CLEANUP flag is set.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@testing-library/vue](https://github.com/testing-library/vue-testing-library) from 7.0.0 to 8.0.1.
- [Release notes](https://github.com/testing-library/vue-testing-library/releases)
- [Commits](testing-library/vue-testing-library@v7.0.0...v8.0.1)

---
updated-dependencies:
- dependency-name: "@testing-library/vue"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 4, 2023
Copy link

stackblitz bot commented Dec 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Pull Request Review Markdown Doc

Hey there! 👋 Here's a summary of the previous results for your Pull Request review. Let's dive in!

Changes ✨

  1. Updated version of @testing-library/vue from ^7.0.0 to ^8.0.1 in package.json. (Commit)

Suggestions 🤔

  1. In package.json, consider updating @tachibana-shin/vite-plugin-pages from 0.31.1-beta.1 to a stable version.
  2. In pnpm-lock.yaml, consider updating function-bind from 1.1.1 to 1.1.2.

Bugs 🐛

  1. In pnpm-lock.yaml, there is a potential bug in the resolution of @babel/runtime. It is currently set to version 7.22.5, but it should be updated to 7.23.2 to match the dependency in /jimp@0.14.0.
  2. In pnpm-lock.yaml, there is a potential bug in the resolution of regenerator-runtime. It is marked as a dev dependency, but it should be removed.

Improvements 🚀

  1. In pnpm-lock.yaml, the dependency resolution for regenerator-transform@0.15.1 and regenerator-transform@0.15.2 can be refactored to use a single entry with an array of versions. Check out the code snippet in the commit for more details.

Rating ⭐️

Overall, the code has been rated 7.5 out of 10. The code shows potential for improvement in terms of updating dependencies and resolving potential bugs. However, without further context, it is difficult to assess the code's overall readability, performance, and security.

That's it for the summary! Let me know if you need any further assistance. Happy reviewing! 😄

Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3d6926) 19.51% compared to head (e3a62ce) 19.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   19.51%   19.51%           
=======================================
  Files          26       26           
  Lines         748      748           
  Branches      196      196           
=======================================
  Hits          146      146           
  Misses        557      557           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Dec 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tachibana-shin tachibana-shin merged commit 79f428a into main Dec 5, 2023
35 checks passed
@tachibana-shin tachibana-shin deleted the dependabot/npm_and_yarn/testing-library/vue-8.0.1 branch December 5, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant