Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Django 2.1.2, remove ColdStartRating #636

Merged
merged 3 commits into from Oct 7, 2018
Merged

Conversation

jilljenn
Copy link
Member

@jilljenn jilljenn commented Oct 5, 2018

  • Fix on_delete (now required)
  • Remove useless middlewares
  • Remove ColdStartRating entirely
  • Replace django.core.resolvers with django.urls
  • Fix tests (exceptions are now returned by Django)
  • Remove scipy from mangaki requirements (but it is still needed in zero)

@jilljenn jilljenn changed the title Bump Django 2.0.8, remove ColdStartRating Bump Django 2.1.2, remove ColdStartRating Oct 6, 2018
@codecov
Copy link

codecov bot commented Oct 6, 2018

Codecov Report

Merging #636 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   82.12%   82.12%   -0.01%     
==========================================
  Files          50       50              
  Lines        2311     2310       -1     
==========================================
- Hits         1898     1897       -1     
  Misses        413      413
Impacted Files Coverage Δ
mangaki/mangaki/utils/archive_export.py 36.84% <ø> (ø) ⬆️
mangaki/mangaki/utils/recommendations.py 98.14% <ø> (-0.04%) ⬇️
mangaki/mangaki/settings.py 72.54% <ø> (ø) ⬆️
mangaki/mangaki/wrappers/anilist.py 87% <100%> (ø) ⬆️
mangaki/mangaki/utils/work_merge.py 91.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a33bc5...679c7e7. Read the comment docs.

@jilljenn jilljenn merged commit 6a6153f into master Oct 7, 2018
@jilljenn jilljenn deleted the jj/bump-django-2 branch October 7, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants