Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[10855] Add TARGET_AREAEFFECT_GO_AROUND_DEST(52) (renamed from TARGET…
…_AREAEFFECT_CUSTOM_2) Target selects all gameobject around destination, limited by adding spell with a corresponding gameobject entry in database table spell_script_target. Signed-off-by: NoFantasy <nofantasy@nf.no>
- Loading branch information
NoFantasy
committed
Dec 11, 2010
1 parent
d026482
commit f121f4e
Showing
6 changed files
with
100 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#ifndef __REVISION_NR_H__ | ||
#define __REVISION_NR_H__ | ||
#define REVISION_NR "10854" | ||
#define REVISION_NR "10855" | ||
#endif // __REVISION_NR_H__ |
f121f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this target mode is used mostly by siege damage spells (like 56350, 61766), is it correct to limit it to spell_script_target?
f121f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because "most" are related to certain spell effects doesn't mean we can allow all spells to handle any gameobject.
f121f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case m_targets.m_targetMask & TARGET_FLAG_SOURCE_LOCATION
lost in this implement :(
f121f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just counting GameObject type 33 and spells with effect 87 gives the need to add 1,575 records in spell_script_target. Are you sure that's a good idea?
f121f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are really-really bored, yes. If not, i would ask myself: "why would I do such a thing when I don't know how this will work for spell effect 87 yet."
The commit does not state anywhere it will work for any kinds of spell effects, nor does it say anywhere the target mode if 100% completed for all spells under any circumstance. In fact, the code contain comments to tell those who bother to read it, that the target mode can not be considered complete. Mangos is a kind of a project where the progression often comes before "100% working, everything implemented zomfg". As far as I can see, there is nothing wrong in the above. Sure, like the code comments already say, there must be room for further improvement, just to avoid adding thousands of spells to database. You can speak of "lost", but the fact is, more spells can work with this commit and I'm happy they can. Next week maybe someone who also care will implement more parts, related to this target mode.
f121f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i think it should be the other way around, if given spell doesnt have spell_script_target then use any GO around, otherwise do an exclusive search with the spell_script_target (maybe)
f121f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What i meant, there are generic spells that meant to hit ANY gameobject, not just predefined ones in spell_script_target.