Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mangrove.js: add unit tests for semibook.estimateVolume #634

Open
adhusson opened this issue Aug 22, 2022 · 3 comments
Open

mangrove.js: add unit tests for semibook.estimateVolume #634

adhusson opened this issue Aug 22, 2022 · 3 comments
Labels
Candidate to be closed enhancement New feature or request triage Issue should be triaged

Comments

@adhusson
Copy link
Contributor

adhusson commented Aug 22, 2022 •
edited by espendk
Loading

The new estimateVolume simulates the workings of mangrove's marketOrder -- we should add tests that ensure the two routines are equivalent, modulo the 2^256-1 ceiling in solidity.
@adhusson adhusson added enhancement New feature or request triage Issue should be triaged labels Aug 22, 2022
@adhusson adhusson self-assigned this Aug 22, 2022
@espendk
Copy link
Collaborator

espendk commented Jan 26, 2023

A number of tests of estimateVolume have been added here: https://github.com/mangrovedao/mangrove-ts/blob/b2d781c0768ef6cfe288165d10586f2deae4d313/packages/mangrove.js/test/integration/semibook.integration.test.ts#L402-L665

Are these sufficient or is more/something else needed?

@peterMangrove
Copy link
Contributor

@espendk Can this be closed, it seems tests has been added?

@espendk
Copy link
Collaborator

espendk commented Feb 8, 2023

I'll pass that question on to @adhusson :-)

@sync-by-unito sync-by-unito bot closed this as completed Jun 19, 2023
@espendk espendk reopened this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Candidate to be closed enhancement New feature or request triage Issue should be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adhusson @espendk @peterMangrove