Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API function taking addresses should also accept names #800

Open
jkrivine opened this issue Oct 5, 2022 · 1 comment
Open

API function taking addresses should also accept names #800

jkrivine opened this issue Oct 5, 2022 · 1 comment
Labels
bug Something isn't working Priority 3 Priority 3 on a scale from 1 to 5. triage Issue should be triaged

Comments

@jkrivine
Copy link
Collaborator

jkrivine commented Oct 5, 2022 •
edited by espendk
Loading

Currently the API is not uniform in treating address parameters.
mgv.token('NameOrAddress') vs. mgv.token('USDC').transfer('addressOnly')

All functions accepting a pure address should also accept a name.
@jkrivine jkrivine added bug Something isn't working triage Issue should be triaged labels Oct 5, 2022
@peterMangrove
Copy link
Contributor

All methods on MgvTokenthat uses an address, should be able to use a name instead.
Solution: Check whether the string is an address, if not, try and look up the string on mgv to find the address.

@peterMangrove peterMangrove added the Priority 3 Priority 3 on a scale from 1 to 5. label Feb 8, 2023
@sync-by-unito sync-by-unito bot closed this as completed Jun 19, 2023
@espendk espendk reopened this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Priority 3 Priority 3 on a scale from 1 to 5. triage Issue should be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jkrivine @espendk @peterMangrove