feat: make totalGave, totalGot, partialFill not undefined #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Amas
force-pushed
the
feat/louis/separate-clean-summary-from-order
branch
from
4e03e38
to
494899e
Compare
Louis-Amas
force-pushed
the
feat/louis/add-totalgot-and-totalgave-to-order-summary
branch
from
bc10005
to
c928476
Compare
Louis-Amas
changed the base branch from
feat/louis/separate-clean-summary-from-order
to
develop
…/louis/add-totalgot-and-totalgave-to-order-summary
Louis-Amas
changed the base branch from
develop
to
feat/louis/separate-clean-summary-from-order
lnist
reviewed
Nov 29, 2023
Louis-Amas
merged commit c50d4f9
into
feat/louis/separate-clean-summary-from-order
3 checks passed
Louis-Amas
deleted the
feat/louis/add-totalgot-and-totalgave-to-order-summary
branch
Louis-Amas
added a commit
that referenced
this pull request
Nov 29, 2023
* feat: separate-clean-summary-from-order * fix: add removed tests * feat: make totalGave, totalGot, partialFill not undefined (#1637) * feat: make totalGave, totalGot, partialFill not undefined * fix: compile errors * feat: create a specific type for cleaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/0/1205905634724379/f