Fix possible infinite recursion in TerraformImportCommand

manheim · Jul 7, 2022 · 42eed27 · 42eed27
1 parent 20765fb
commit 42eed27
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -5,3 +5,6 @@ build
 .idea
 *.iml
 /out
+.history
+bin
+.vscode
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # Unreleased
 
+- [Issue #439](https://github.com/manheim/terraform-pipeline/issues/439) Fix possible infinite recursion in TerraformImportCommand
 - [Issue #432](https://github.com/manheim/terraform-pipeline/issues/432) pass TagPlugin through `-var-file={env}-tags.tfvars`
 - [Issue #417](https://github.com/manheim/terraform-pipeline/issues/417) DestroyPlugin & PassPlanFilePlugin - Terraform Destroy can't be called with a plan file
 

diff --git a/src/TerraformImportCommand.groovy b/src/TerraformImportCommand.groovy
@@ -35,7 +35,7 @@ class TerraformImportCommand implements TerraformCommand, Resettable {
     }
 
     public String getTargetPath() {
-        return this.targetPath
+        return targetPath
     }
 
     public TerraformImportCommand withTargetPath(String targetPath) {
@@ -44,7 +44,7 @@ class TerraformImportCommand implements TerraformCommand, Resettable {
     }
 
     public String getResource() {
-        return this.resource
+        return resource
     }
 
     public static void reset() {
@@ -97,6 +97,6 @@ class TerraformImportCommand implements TerraformCommand, Resettable {
     }
 
     public String getEnvironment() {
-        return this.environment
+        return environment
     }
 }