Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Plugin Architecture #152

Open
kmanning opened this issue Sep 3, 2019 · 0 comments
Open

Simplify Plugin Architecture #152

kmanning opened this issue Sep 3, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone
v6.0

Comments

@kmanning
Copy link
Collaborator

kmanning commented Sep 3, 2019

  • The plugins have a clear interface, but it may be overly specific.
  • Part of the specificity is the decorate method.
  • Consider defaulting the ALL argument of decorate - if you call decorate and only pass it a closure, it should default to ALL
  • Consider rewriting some plugins to use ALL unless it's absolutely necessary.
  • Consider pushing decorate into a the Stage interface.
  • If we did the above, I think the plugin implementation could be a lot more simple and flexible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v6.0
Development

No branches or pull requests
1 participant
@kmanning