Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - Create new ParametersPlugin #272

Closed
kmanning opened this issue Aug 1, 2020 · 1 comment · Fixed by #273
Closed

Refactor - Create new ParametersPlugin #272

kmanning opened this issue Aug 1, 2020 · 1 comment · Fixed by #273
Milestone
v5.9

Comments

@kmanning
Copy link
Collaborator

kmanning commented Aug 1, 2020 •
edited
Loading

  • Refactor Jenkinsfile/TargetPlugin/PlanOnlyPlugin to rely on a new ParametersPlugin
    • Parameters should not live in Jenkinsfile
  • Do TargetPlugin and PlanOnlyPlugin work on pipeline that only has one stage? - No, defect
@kmanning kmanning added this to the v5.9 milestone Aug 1, 2020
@kmanning kmanning mentioned this issue Aug 2, 2020
Merged
@kmanning
Copy link
Collaborator Author

kmanning commented Aug 2, 2020

Chip away at Issue #152 : create a temporary DecoratableStage interface. This functionality should be pushed into the Stage interface, but I don't want to break any existing external Stages in a minor release.

@kmanning kmanning linked a pull request Aug 2, 2020 that will close this issue
Issue #272: refactor parameters into a plugin #273
Merged
kmanning added a commit that referenced this issue Aug 2, 2020
@kmanning
Merge pull request #273 from kmanning/issue_272
9b4fc27 
Issue #272: refactor parameters into a plugin
@kmanning kmanning mentioned this issue Aug 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.9
Development

Successfully merging a pull request may close this issue.

Issue #272: refactor parameters into a plugin kmanning/terraform-pipeline
1 participant
@kmanning