Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagPlugin - support both terraform 0.11 and 0.12 #289

Closed
kmanning opened this issue Aug 13, 2020 · 1 comment · Fixed by #291
Closed

TagPlugin - support both terraform 0.11 and 0.12 #289

kmanning opened this issue Aug 13, 2020 · 1 comment · Fixed by #291
Labels
bug Something isn't working
Milestone

Comments

@kmanning
Copy link
Collaborator

  • Is the -var different between 11 and 12?
  • the plugin uses -var="key=value", but the equal sign might be causing problems with v0.11.
  • Either remove the = (assuming that works in 12), or build this difference in TerraformVersionPlugin.
@kmanning kmanning added the bug Something isn't working label Aug 13, 2020
@kmanning
Copy link
Collaborator Author

kmanning commented Aug 13, 2020

See terraform docs

Note that there are 2 differences:

  1. 11: -var 'key=..., 12: -var='key=...
  2. 11: map={key="value"}, 12: map={"key":"value"}

@kmanning kmanning changed the title TagPlugin - support terraform 0.11 TagPlugin - support both terraform 0.11 and 0.12 Aug 17, 2020
@kmanning kmanning linked a pull request Aug 17, 2020 that will close this issue
@kmanning kmanning added this to the v5.10 milestone Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant