Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 87: run tests through travis CI #182

Merged
merged 10 commits into from
Jan 23, 2020
Merged

Conversation

kmanning
Copy link
Collaborator

@kmanning kmanning commented Jan 22, 2020

  • Run unit tests through travis CI
  • Tests have been refactored - TravisCI uncovered subtle problems with the unit tests
    • Global variables Jenkinsfile.instance are being modified, and affecting subsequent tests. Let's walk away from modifying global variables all together while writing unit tests.

@kmanning
Copy link
Collaborator Author

Travis running against my personal account https://travis-ci.com/kmanning/terraform-pipeline/builds/145617026

Copy link
Contributor

@vincentclee vincentclee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kmanning kmanning changed the base branch from master to v5.4-dev January 22, 2020 20:34
@kmanning kmanning force-pushed the issue_87 branch 2 times, most recently from 6ac3cf6 to f73ba21 Compare January 22, 2020 20:47
@kmanning
Copy link
Collaborator Author

kmanning commented Jan 22, 2020

More work left for Issue #87 - add code coverage reports, and checkstyle. Handle this in another PR.

@kmanning kmanning merged commit 5301726 into manheim:v5.4-dev Jan 23, 2020
@kmanning kmanning deleted the issue_87 branch February 6, 2020 03:16
@kmanning kmanning added this to the v5.4 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants