Issue 87 Part 3: Add codenarc and fix terraform-version comparison #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v5.4-dev #188 +/- ##
=========================================
Coverage 52.35% 52.35%
=========================================
Files 31 31
Lines 764 764
Branches 207 207
=========================================
Hits 400 400
Misses 283 283
Partials 81 81
Continue to review full report at Codecov.
|
|
Note: this problem was identified in the original author's PR - https://github.com/manheim/terraform-pipeline/pull/173/files#diff-2724a09cdd048285c15140f07b77fb5dR47-R51 The return of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Terraform Pipeline needs CI #87
The initial merge of issue_87_part_3 introduced a regression, when refactoring version comparison to use
>=.The compareTo method of SemanticVersion doesn't properly override the various comparison operators. It also behaves differently in unit tests than it does under a normal Jenkinsfile context.
Switch to
<=>operator instead of>=when comparing semantic versions, to determine whether or not to use Terraform v0.12 workflow.Test:
new SemanticVersion('0.12.0') >= new SemanticVersion('0.12.0')Expected:
trueActual:
0