Issue #254: GithubPlanPR bug fix

[jleopold28]

See #254

[codecov-commenter]

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files          38       38           
  Lines         931      931           
  Branches      229      229           
=======================================
  Hits          686      686           
  Misses        132      132           
  Partials      113      113           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9466ef7...64a6d7b. Read the comment docs.

[kmanning]

Can you add a unit tests for this?

There's already a unit test that confirms that we're using the correct protocol. Seems like we need an additional test case that says that if the protocol is git, it overrides it to https. https://github.com/manheim/terraform-pipeline/blob/master/test/GithubPRPlanPlugin.groovy#L165-L175

Looks like overriding the host is already covered by a unit test - https://github.com/manheim/terraform-pipeline/blob/master/test/GithubPRPlanPlugin.groovy#L141-L151

[jleopold28]

@kmanning Unit test added