-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #354: Add taint and untaint command #353
Issue #354: Add taint and untaint command #353
Conversation
In the meantime, @duckpuppy, how would you feel about removing the |
class TerraformTaintCommand implements TerraformCommand, Pluggable<TerraformTaintCommandPlugin> { | ||
private String command = "taint" | ||
private String resource | ||
private String environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is environment
dead code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gross, it's part of the TerraformCommand
interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cutting a separate issue for that - #357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was part of why I moved environment management into it when I was converting it to a trait - it already had getEnvronment() in the interface.
Looks good, |
The
TerraformTaintPlugin
adds new parameters to a build for resources to taint / untaint. If nothing is specified, then the plugin does nothing. If a value is provided in one of the parameters, then the corresponding command will be ran prior to theterraform plan
command. It also includes support for restricting the execution to a given branch or set of branches, as well as restricting based the origin repository of the code checked out in the workspace.Fixes #354