Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 214: CredentialsPlugin - support more than username/password #403

Merged
merged 13 commits into from
Aug 31, 2021

Conversation

kmanning
Copy link
Collaborator

@kmanning kmanning commented Aug 27, 2021

CredentialsPlugin currently only supports username/password, but there are many more. Support all types of credential bindings.

Merge Checklist

  • Have you linked this Pull Request to an Issue?
  • Have you updated any relevant README files, to explain how this new feature works (with examples)?
  • Have you added relevant test cases for your change?
  • Do all tests and code style checks pass with ./gradlew check --info?
  • Have you successfully run your change in a pipeline in a Jenkins instance?
  • Have you updated the CHANGELOG?

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #403 (a99eca9) into master (110d929) will increase coverage by 0.23%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   82.06%   82.30%   +0.23%     
==========================================
  Files          53       53              
  Lines        1455     1452       -3     
  Branches      307      307              
==========================================
+ Hits         1194     1195       +1     
+ Misses        119      115       -4     
  Partials      142      142              
Impacted Files Coverage Δ
src/CredentialsPlugin.groovy 73.07% <88.88%> (+11.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110d929...a99eca9. Read the comment docs.

Copy link
Contributor

@codezninja codezninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change work as expected. Looks great.

@kmanning kmanning merged commit a14c20d into manheim:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CredentialsPlugin should support more than username/password credentials
3 participants