Import AsyncStorage from @react-native-async-storage to silence warning #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsjoberg
reviewed
Jul 2, 2023
| "homepage": "https://github.com/manicakes/react-native-icloudstore#readme" | ||
| "homepage": "https://github.com/manicakes/react-native-icloudstore#readme", | ||
| "dependencies": { | ||
| "@react-native-async-storage/async-storage": "^1.17.0" |
There was a problem hiding this comment.
If I understand things right, this should be under peerDependencies, not dependencies.
Like this:
hsjoberg@a68dc9c#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R24
|
@manicakes Please merge this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to replace the deprecated import from react-native with the new package @react-native-async-storage.
I am not sure whether we need to add react-native to the dependencies as well or why it was not listed before.