Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Features: Create, Get, List, Update #219
base: main
Are you sure you want to change the base?
Chat Features: Create, Get, List, Update #219
Changes from 4 commits
221f25b
3a4f088
b6ca816
0fa6c9a
f9e3ac4
e752c65
f9a8a60
649bd16
52f43cc
9bb3631
72150e9
7c6ef67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are bind records, it looks like the odata type is required here, and also the ID needs to be sent as a full odata ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for taking this PR on without understanding this part.
Can you link an example of where the OdataID is passed in a full context? I must be missing the apparent examples elsewhere in the code.
My understanding from your first part is that it needs to be:
And then the odata.TypeConversationMember be added as a type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Threpio No apologies are needed - thank you for working on this, it is very appreciated.
Perhaps it is also possible to specify the regular ID and a type instead of the OData ID?
I noted my original comment from the docs where there is an example showing members being set using an OData bind field:
There are other places in the SDK where we handle this type of field, for example see the
Group
model:The
Members
field marshals tomembers@odata.bind
and it should be populated by the user with OData IDs, which take the form:https://graph.microsoft.com/v1/users/00000000-0000-0000-0000-000000000000
You should be able to re-use the
Members
type here too, as this has its own marshaler and unmarshaler funcs to help with parsing values.Hope this helps!