Skip to content

Commit

Permalink
Add other breaking changes jupyterhub#1521 jupyterhub#1581 jupyterhub…
Browse files Browse the repository at this point in the history
  • Loading branch information
manics committed Dec 16, 2022
1 parent 63c1c1c commit a822ce1
Showing 1 changed file with 25 additions and 1 deletion.
26 changes: 25 additions & 1 deletion CHANGES.md
Expand Up @@ -13,7 +13,11 @@ make it easier to track what has changed over time_

## Breaking changes

The `binderhub.build.Build` class is replaced by the Traitlets based `binderhub.build.KubernetesBuildExecutor` class [#1581](https://github.com/jupyterhub/binderhub/pull/1581), [#1521](https://github.com/jupyterhub/binderhub/pull/1521).
### `binderhub.build.Build` replaced by `binderhub.build.KubernetesBuildExecutor`

The `binderhub.build.Build` class is replaced by the Traitlets based `binderhub.build.KubernetesBuildExecutor` class
[#1518](https://github.com/jupyterhub/binderhub/pull/1518),
[#1521](https://github.com/jupyterhub/binderhub/pull/1521).
The following build configuration properties should be set using Traitlets in the BinderHub configuration:

- `c.BinderHub.appendix` ➡️ `c.BuildExecutor.appendix`
Expand All @@ -30,6 +34,26 @@ The following build configuration properties should be set using Traitlets in th
If you have subclassed `binderhub.build.Build` you must update your subclass (including `__init__()` if defined) to inherit from `binderhub.build.KubernetesBuildExecutor`.
The behaviour of the class is otherwise unchanged.

### `dind.enabled` replaced by `imageBuilderType: dind`

The BinderHub builder has been generalised to support non-docker implementations
[#1531](https://github.com/jupyterhub/binderhub/pull/1531).
If you are using Docker-in-Docker replace:

- `dind.enabled: true` ➡️ `imageBuilderType: dind`

The `component: dind` pod builder label is changed to `component: image-builder`
[#1543](https://github.com/jupyterhub/binderhub/pull/1543)

### `imageCleaner.host.enabled` replaced by`imageCleaner.enabled`

When Docker-in-Docker (dind) is enabled the image cleaner used to be run in Docker-in-Docker and on the host Docker.
This is no longer the case, the image cleaner is only run in one place
[#1588](https://github.com/jupyterhub/binderhub/pull/1588).
If you were previously disabling the image cleaner replace:

- `imageCleaner.host.enabled: false` ➡️ `imageCleaner.enabled: false`

# 0.2.0

# master@{2019-07-01}...master@{2019-10-01}
Expand Down

0 comments on commit a822ce1

Please sign in to comment.