Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Night version of icons #2

Closed
tschaefer opened this issue Mar 12, 2017 · 22 comments
Closed

Night version of icons #2

tschaefer opened this issue Mar 12, 2017 · 22 comments

Comments

@tschaefer
Copy link

Hi,

very nice set of Wunderground icons, would be very nice to have a night version, moon instead of sun.
Maybe you've got the muse to create them. 🕺

Cheers.

@tschaefer
Copy link
Author

Oh, just saw the icons haven't be done by you. Sorry for the noise ...

@manifestinteractive
Copy link
Owner

@tschaefer Yep, sadly I am not the awesome designer that made these. But I did get her permission to port them over to something us developers can use. I do like the idea of this though so I am going to re-open the issue in case anyone in the community wants to tackle this.

I think editing the SVG files should be pretty straight forward and you could just swap out the moon for the sun in some cases, would still be a bit of work, but totally doable.

@manifestinteractive
Copy link
Owner

@tschaefer what are your thoughts on how the day/night icons could be organized in this project? You thinking separate folders ( eg day/clear.png night/clear.png ) or maybe a name suffix ( eg clear-day.png clear-night.png ) ?

@tschaefer
Copy link
Author

tschaefer commented Mar 13, 2017

@manifestinteractive I would prefer to put the day/night icons in seperate folders. I'm using only the icons - not the css stuff - for my menubar (tint2) in WM Openbox, see screenshot.

@7ooL
Copy link

7ooL commented Jun 17, 2017

i'd also like to see night versions

@cawa-93
Copy link

cawa-93 commented Sep 15, 2017

+1

@lorol
Copy link

lorol commented Sep 19, 2017

+1,
As for the night names, you can use "nt_" prefix like WunderGround approach.
In fact only 2 new "night" icons + some logic how you pick others on day/night condition, can cover simplistically the need:

  1. nt_mostlycloudy = nt_mostlysunny = nt_partlycloudy = nt_partlysunny
    
  2. nt_sunny = nt_clear
    

@W0CHP
Copy link

W0CHP commented Nov 21, 2017

👍 +1

This project implements icons for night.
However, I like this project's simple implementation, prefer its icons, and would love night icons.

I wish I could help in some way, but I can barely draw a stick figure :-/

@manifestinteractive
Copy link
Owner

Question for those interested in this issue. I am going to be working on a personal project that would benefit from these night time icons as well and wondering how we should handle the moon design.

While we could easily just make a simple round moon, my thoughts are that we also have an opportunity to represent the phases of the moon.

Seems like if the sky is clear and we are using night time icons, we could hit the astronomy API endpoint to figure out the current phase of the moon.

I would love to hear everyones thoughts on what "night version" truly means, as IMO it's more complex than just swapping out the sun for a moon.

@lorol
Copy link

lorol commented Nov 26, 2017

Hi, @manifestinteractive
IMO, night addition should be simplistic and compatible to the nice set you already made.
Just to correspond to WU sets and names
If you want to complicate it with detailed moon states, please do this in separate group.

@7ooL
Copy link

7ooL commented Nov 26, 2017

some time ago i just made some variants of night icons off this project for my needs. i have them posted here. I only ever did .png images in 64x64 and 128x128, there was only about 6 images that had the sun swapped for the moon for each size.
https://github.com/7ooL/Weather-Underground-Icons

@W0CHP
Copy link

W0CHP commented Nov 26, 2017

@manifestinteractive
Cool idea for another astrological project I’m working on using PyEphem, but for the sake of displaying simple WX conditions at night while leveraging the existing “nt_” api responses, I fully agree with @lorol.

@manifestinteractive
Copy link
Owner

Here is what I am working on, should have committed in an hour or so:

icon-preview
icon-preview

@lorol
Copy link

lorol commented Nov 27, 2017

Not sure but IMO a generic moon should look something like this:
moon
But you are designer, I am thinking too standard and practical. indeed the ones you proposed have identity, I could be wrong!

@manifestinteractive
Copy link
Owner

@lorol I'm always partial to the full moon, but yes, the most common representation is what you provided. I will make that update on the three images. I'm also packing up a solid color version of each as well, as I have had a need for these icons as either all black, or all white, with none of the blue / yellow stuff in it.

@lorol
Copy link

lorol commented Nov 27, 2017

:) in this case, you can make the moon just very-very slightly bitten either left or right upper side, like the apple symbol.
It may look very nice.

@lorol
Copy link

lorol commented Nov 27, 2017

@manifestinteractive, here is the (almost) full nt_ name list from the API.
Hope it will bring you some idea of what else is worth to be in a separate icon, what can be merged within nt's and what with dailies:

nt_chanceflurries
nt_chancerain
nt_chancesleet
nt_chancesnow
nt_chancetstorms
nt_clear
nt_cloudy
nt_flurries
nt_fog
nt_hazy
nt_mostlycloudy
nt_mostlysunny
nt_partlycloudy
nt_partlysunny
nt_sleet
nt_rain
nt_snow
nt_sunny :)
nt_tstorms

@manifestinteractive
Copy link
Owner

ah, so since most of these are going to be the exact same icon, are you wanting them duplicated ? If so, I will need to spend several more hours on this, not so much that making the icons is hard, just the updating the CSS, docs, demo app, etc ... all that gets factored in with the change. So if we can agree that the crescent moon shape you provided is ideal, and that we need an nt_ prefix for each icon, that sets the acceptance criteria for me to wrap this up.

@manifestinteractive
Copy link
Owner

@lorol Can I get your feedback on these three icons ?

nt_clear
nt_mostlycloudy
nt_mostlysunny

manifestinteractive pushed a commit that referenced this issue Nov 27, 2017
* Add Night Version of Icons
* Add Solid Black Icons
* Add Solid White Icons

Fixes issue #2
@manifestinteractive
Copy link
Owner

This issue is now resolved with the release of v1.0.1 which is currently in the master branch. If there are any requested changes to these new night time icons, let's open a new issue :)

@W0CHP
Copy link

W0CHP commented Nov 27, 2017

Looks perfect and thank you @manifestinteractive!

@lorol
Copy link

lorol commented Nov 27, 2017

I like them, too! Thank you.
I don't know what is the best solution to map all names (~40 total) - by duplicating icons or some kind of "universal" lookup. Especially on embedded projects, the space is tight to afford dummy copies and you have to do custom "name to bitmap" recognition in the code anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants