Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Encapsulate manifold run. #126

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Encapsulate manifold run. #126

merged 1 commit into from
Dec 14, 2018

Conversation

jelmersnoeck
Copy link
Contributor

Manifold Run doesn't work on PRs due to Travis' set up with regards to
secrets.

Manifold Run is only needed when we release the image - to inject the
docker credentials. We don't need to do this when we run tests and
linting.

Let's move it to only run when we build the images (after merging a PR)
so that we can ensure PRs still build.

Manifold Run doesn't work on PRs due to Travis' set up with regards to
secrets.

Manifold Run is only needed when we release the image - to inject the
docker credentials. We don't need to do this when we run tests and
linting.

Let's move it to only run when we build the images (after merging a PR)
so that we can ensure PRs still build.
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   33.69%   33.69%           
=======================================
  Files          26       26           
  Lines        2704     2704           
=======================================
  Hits          911      911           
  Misses       1718     1718           
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9988c2b...3ace013. Read the comment docs.

@jelmersnoeck jelmersnoeck merged commit dbcd22a into master Dec 14, 2018
@jelmersnoeck jelmersnoeck deleted the encapsulate-manifold-run branch December 14, 2018 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants