This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Change the registry api to return a tag name #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This opens things up for us to select a tag name that doesn't match the github release name.
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 18.96% 19.12% +0.15%
==========================================
Files 22 23 +1
Lines 2452 2458 +6
==========================================
+ Hits 465 470 +5
- Misses 1956 1957 +1
Partials 31 31
Continue to review full report at Codecov.
|
jelmersnoeck
approved these changes
Jul 10, 2018
| // no matching tag being found. | ||
| func IsTagNotFoundError(err error) bool { | ||
| _, ok := err.(tagNotFoundError) | ||
| return ok |
There was a problem hiding this comment.
I like these type of errors 🙌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens things up for us to select a tag name that doesn't match the
github release name.