Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success template in Prompt is never rendered #70

Closed
hassansin opened this issue Jul 11, 2018 · 1 comment
Closed

Success template in Prompt is never rendered #70

hassansin opened this issue Jul 11, 2018 · 1 comment

Comments

@hassansin
Copy link
Contributor

I'm not sure if this is intended or not but the Success template in PromptTemplates is never rendered. I tried the custom_prompt example and had the same behavior.

I think in this line we could render success template instead. I can send a PR if you agree.

Thanks for this really cool package!
This was referenced Jul 11, 2018
Closed
Merged
@Minivera
Copy link
Contributor

This was fixed in #71, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hassansin @Minivera