Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render prompt success template once prompt completes #71

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Render prompt success template once prompt completes #71

merged 1 commit into from
Jul 12, 2018

Conversation

hassansin
Copy link
Contributor

As mentioned in #70 Success template in PromptTemplates is never rendered when prompt completes

@manifold-listbot
Copy link

Author

  • Changelog has been updated

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

Minivera
Minivera approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@Minivera Minivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested an working on our end, thanks for the contribution. I will merge this PR and we will proceed to deploy it soon.

@Minivera Minivera merged commit d994d9b into manifoldco:master Jul 12, 2018
@Minivera Minivera mentioned this pull request Jul 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minivera Minivera Minivera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hassansin @manifold-listbot @CLAassistant @Minivera