Stop attempting to convert credentials to numbers #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We support types for credentials, which is nice. However, we can't accurately know if a string given to us on the command line that *looks* like a number really should be a number. If we assume it should be a number, we end up losing data, like leading zeros, or converting long decimals to scientific notation. For values given on the command line, stop attempting to convert the value, and instead store it as a string. Closes #163
ianlivingstone
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support types for credentials, which is nice. However, we can't
accurately know if a string given to us on the command line that looks
like a number really should be a number.
If we assume it should be a number, we end up losing data, like leading
zeros, or converting long decimals to scientific notation.
For values given on the command line, stop attempting to convert the
value, and instead store it as a string.
Closes #163