Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manifold theme to Storybook #264

Merged
merged 1 commit into from Jul 15, 2019
Merged

Add Manifold theme to Storybook #264

merged 1 commit into from Jul 15, 2019

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Jul 15, 2019

Reason for change

When we’re developing styles, we weren’t looking at our own styles! Let’s use our styles at least as the default.

This also has a secondary benefit of providing our design team with accurate, interactive versions of our component system.

Screen Shot 2019-07-15 at 08 49 37

Testing

Check out the new Storybook preview link below under Now (Heroku is still used to show the Gatsby docs)! 🎉

@vercel
Copy link

vercel bot commented Jul 15, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://ui-git-dangodev-manifold-styles.manifold.now.sh

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   60.11%   60.11%           
=======================================
  Files          42       42           
  Lines        1008     1008           
  Branches      235      235           
=======================================
  Hits          606      606           
  Misses        387      387           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20929f6...a811f5b. Read the comment docs.

@drwpow drwpow requested a review from Minivera July 15, 2019 18:34
Copy link
Contributor

@markjamieson markjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an issue I saw when reviewing some @Minivera PRs. It had seemed like Storybook wasn't picking up on some of the global vars, but this seems to fix it!

@drwpow drwpow merged commit 8821393 into master Jul 15, 2019
@drwpow drwpow deleted the dangodev/manifold-styles branch July 15, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants