Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo contract resolution #1515

Merged
merged 4 commits into from Feb 13, 2023
Merged

Undo contract resolution #1515

merged 4 commits into from Feb 13, 2023

Conversation

IanPhilips
Copy link
Collaborator

@IanPhilips IanPhilips commented Feb 13, 2023

This doesn't undo all trades, just the final payouts and sets the contract back to its last, unresolved state. The admin should resolve the market ASAP after undoing the resolution.

I've tested this on dev and it worked, too!

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 4:15PM (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 4:15PM (UTC)
prod ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 4:15PM (UTC)

Copy link
Collaborator

@mantikoros mantikoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should add an admin button on the resolve panel to support un-resolution too.

backend/scripts/undo-resolution.ts Show resolved Hide resolved
backend/shared/src/run-txn.ts Show resolved Hide resolved
@IanPhilips IanPhilips merged commit eee95f9 into main Feb 13, 2023
@IanPhilips IanPhilips deleted the undo-contract-resolution branch February 13, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants