Automated market resolution #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should this be done in the repo or should everyone using VS Code do that himself globally on his machine(s)?
# Conflicts: # web/components/choices-toggle-group.tsx # web/pages/create.tsx
# Conflicts: # common/contract.ts # functions/src/create-contract.ts # web/pages/create.tsx
This reverts commit 22f59ad.
…solution # Conflicts: # web/components/contract/contract-info-dialog.tsx
jahooma
approved these changes
Jun 14, 2022
jahooma
reviewed
Jun 15, 2022
| @@ -113,6 +116,7 @@ export const createmarket = newEndpoint(['POST'], async (req, auth) => { | |||
| ante, | |||
| closeTime.getTime(), | |||
| tags ?? [], | |||
| autoResolutionTime, | |||
There was a problem hiding this comment.
This is not in the right order, autoResolutionTime should be the last parameter. (To make this more robust, we could switch to taking all the parameters as an object instead of a param list. Not sure if that should be part of this change.)
| firestore | ||
| .collection('contracts') | ||
| .where('isResolved', '==', false) | ||
| .where('closeTime', '>', Date.now()) |
There was a problem hiding this comment.
closeTime should be '<' Date.now() if the market is closed!
| .collection('contracts') | ||
| .where('isResolved', '==', false) | ||
| .where('closeTime', '>', Date.now()) | ||
| .where('autoResolutionTime', '<', Date.now()) |
There was a problem hiding this comment.
Firebase does not allow two queries with not equal operators. Advice is to move the closeTime query into a filter operation after loading the contracts.
| ) | ||
|
|
||
| export const autoResolveMarkets = functions.pubsub | ||
| .schedule('every 1 minutes') |
There was a problem hiding this comment.
Needs .runWith({ secrets: ['MAILGUN_KEY'] }) since it sends emails.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will brings automatic resolutions to abandoned markets.
Automatic resolution means that unresolved markets get resolved as 'MKT' (paying out investors according to the current odds) at a specified date. By default that date is 1 week after the market closes but it can be modified by the market creator.
Features
Already done on prod
ToDo prod db
Possible features for later PRs
Untested