Notify mentioned users on market publish #683

sipec · 2022-07-22T00:02:29Z

commit order is a bit fucked, but this is meant to be after #670 and #681 get merged

vercel · 2022-07-22T00:02:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
dev	✅ Ready (Inspect)	Visit Preview	Jul 24, 2022 at 4:18PM (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Jul 24, 2022 at 4:18PM (UTC)
opengraph-image	✅ Ready (Inspect)	Visit Preview	Jul 24, 2022 at 4:18PM (UTC)
prod	✅ Ready (Inspect)	Visit Preview	Jul 24, 2022 at 4:18PM (UTC)

IanPhilips · 2022-07-22T13:37:20Z

functions/src/create-notification.ts

-  relatedUserId?: string,
-  sourceSlug?: string,
-  sourceTitle?: string
+  miscData?: {


Nice! This is much cleaner

IanPhilips · 2022-07-22T13:37:50Z

functions/src/create-notification.ts

@@ -144,21 +154,24 @@ export const createNotification = async (
      }
  }

-  const notifyTaggedUsers = async (
+  /** @deprecated parse from rich text instead */
+  const parseMentions = async (source: string) => {


any reason not to just remove it entirely?

Oh I see it's used in the comments for now

IanPhilips · 2022-07-22T13:39:07Z

functions/src/on-create-bet.ts

-      contract.slug,
-      contract.question
+      {
+        contract,


Much nicer!

IanPhilips · 2022-07-22T13:40:23Z

web/components/editor/mention-suggestion.ts

+// copied from https://tiptap.dev/api/nodes/mention#usage
+export const mentionSuggestion = (users: User[]): Suggestion => ({
+  items: ({ query }) =>
+    users.filter((u) => searchInAny(query, u.username, u.name)).slice(0, 5),


Have you tried this on prod? My user filtering was fine on dev but super laggy on group adds bc I assume there were too many users to filter. Maybe it was something else though!

IanPhilips

Looks great, thanks for changing the call signature to be more explicit and I'm excited about the new mentions menu!

- refactor createNotification to accept list of recipients' ids

IanPhilips · 2022-08-02T15:36:56Z

Can we merge this or are we waiting on something?

* Add function to parse at mentions * Notify mentioned users on market create - refactor createNotification to accept list of recipients' ids

* Challenge bets * Store avatar url * Fix before and after probs * Check balance before creation * Calculate winning shares * pretty * Change winning value * Set shares to equal each other * Fix share challenge link * pretty * remove lib refs * Probability of bet is set to market * Remove peer pill * Cleanup * Button on contract page * don't show challenge if not binary or if resolved * challenge button (WIP) * fix accept challenge: don't change pool/probability * Opengraph preview [WIP] * elim lib * Edit og card props * Change challenge text * New card gen attempt * Get challenge on server * challenge button styling * Use env domain * Remove other window ref * Use challenge creator as avatar * Remove user name * Remove s from property, replace prob with outcome * challenge form * share text * Add in challenge parts to template and url * Challenge url params optional * Add challenge params to parse request * Parse please * Don't remove prob * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Add to readme about how to dev og-image * Add emojis * button: gradient background, 2xl size * beautify accept bet screen * update question button * Add separate challenge template * Accepted challenge sharing card, fix accept bet call * accept challenge button * challenge winner page * create challenge screen * Your outcome/cost=> acceptorOutcome/cost * New create challenge panel * Fix main merge * Add challenge slug to bet and filter by it * Center title * Add helper text * Add FAQ section * Lint * Columnize the user areas in preview link too * Absolutely position * Spacing * Orientation * Restyle challenges list, cache contract name * Make copying easy on mobile * Link spacing * Fix spacing * qr codes! * put your challenges first * eslint * Changes to contract buttons and create challenge modal * Change titles around for current bet * Add back in contract title after winning * Cleanup * Add challenge enabled flag * Spacing of switch button * market share row * Add lite market endpoint * 500 mana email (#687) * Create 500-mana.html * Update 500-mana.html Fixed typos and links not working * Added "create a good market" guide added page creating-market.html For Stephen to set up condition (email 3 days after signing up) * Update 500-mana.html updated 500 Mana email (still need to make changes to create market guide) * email changes * sendOneWeekBonusEmail logic * add dayjs as dependency * don't use mailgun scheduling Co-authored-by: mantikoros <sgrugett@gmail.com> * Challenge Bets (#679) * Challenge bets * Store avatar url * Fix before and after probs * Check balance before creation * Calculate winning shares * pretty * Change winning value * Set shares to equal each other * Fix share challenge link * pretty * remove lib refs * Probability of bet is set to market * Remove peer pill * Cleanup * Button on contract page * don't show challenge if not binary or if resolved * challenge button (WIP) * fix accept challenge: don't change pool/probability * Opengraph preview [WIP] * elim lib * Edit og card props * Change challenge text * New card gen attempt * Get challenge on server * challenge button styling * Use env domain * Remove other window ref * Use challenge creator as avatar * Remove user name * Remove s from property, replace prob with outcome * challenge form * share text * Add in challenge parts to template and url * Challenge url params optional * Add challenge params to parse request * Parse please * Don't remove prob * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Challenge card styling * Add to readme about how to dev og-image * Add emojis * button: gradient background, 2xl size * beautify accept bet screen * update question button * Add separate challenge template * Accepted challenge sharing card, fix accept bet call * accept challenge button * challenge winner page * create challenge screen * Your outcome/cost=> acceptorOutcome/cost * New create challenge panel * Fix main merge * Add challenge slug to bet and filter by it * Center title * Add helper text * Add FAQ section * Lint * Columnize the user areas in preview link too * Absolutely position * Spacing * Orientation * Restyle challenges list, cache contract name * Make copying easy on mobile * Link spacing * Fix spacing * qr codes! * put your challenges first * eslint * Changes to contract buttons and create challenge modal * Change titles around for current bet * Add back in contract title after winning * Cleanup * Add challenge enabled flag * Spacing of switch button * Put sharing qr code in modal Co-authored-by: mantikoros <sgrugett@gmail.com> * See challenges you've accepted too * Remove max height * Notify mentioned users on market publish (#683) * Add function to parse at mentions * Notify mentioned users on market create - refactor createNotification to accept list of recipients' ids * Switch comments/chat to rich text editor (#703) * Switch comments/chat to rich text editor * Remove TruncatedComment * Re-add submit on enter * Insert at mention on reply * Update editor style for send button * only submit on enter in chat * code review: refactor * use more specific type for upload * fix ESlint and errors from merge * fix trigger on every render eslint warning * Notify people mentioned in comment * fix type errors * Revert "Switch comments/chat to rich text editor (#703)" This reverts commit f52da72. * merge conflict * share modal * merge issue * eslint * bigger link icion Co-authored-by: Ian Philips <iansphilips@gmail.com> Co-authored-by: James Grugett <jahooma@gmail.com> Co-authored-by: SirSaltyy <104849031+SirSaltyy@users.noreply.github.com> Co-authored-by: Sinclair Chen <abc.sinclair@gmail.com>

sipec changed the base branch from main to editor-at-mention July 22, 2022 00:03

sipec changed the base branch from editor-at-mention to main July 22, 2022 00:03

sipec requested a review from IanPhilips July 22, 2022 00:04

IanPhilips reviewed Jul 22, 2022

View reviewed changes

functions/src/on-create-bet.ts Outdated

contract.slug,

contract.question

{

contract,

Copy link

Collaborator

IanPhilips Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

IanPhilips reviewed Jul 22, 2022

View reviewed changes

IanPhilips approved these changes Jul 22, 2022

View reviewed changes

sipec added 2 commits July 24, 2022 09:14

Add function to parse at mentions

e1c5088

Notify mentioned users on market create

f9e5d86

- refactor createNotification to accept list of recipients' ids

sipec force-pushed the mention-notif branch from 7130174 to f9e5d86 Compare July 24, 2022 16:16

sipec marked this pull request as ready for review July 24, 2022 16:16

vercel bot deployed to Preview – docs July 24, 2022 16:17 View deployment

vercel bot deployed to Preview – dev July 24, 2022 16:17 View deployment

vercel bot deployed to Preview – opengraph-image July 24, 2022 16:18 View deployment

vercel bot deployed to Preview – prod July 24, 2022 16:18 View deployment

sipec merged commit edae709 into main Aug 4, 2022

sipec deleted the mention-notif branch August 4, 2022 22:35

mantikoros pushed a commit that referenced this pull request Aug 5, 2022

Notify mentioned users on market publish (#683)

3e4350c

* Add function to parse at mentions * Notify mentioned users on market create - refactor createNotification to accept list of recipients' ids

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Notify mentioned users on market publish #683

Notify mentioned users on market publish #683

sipec commented Jul 22, 2022 •

edited

vercel bot commented Jul 22, 2022 •

edited

IanPhilips Jul 22, 2022

IanPhilips Jul 22, 2022

IanPhilips Jul 22, 2022

IanPhilips Jul 22, 2022

IanPhilips Jul 22, 2022

IanPhilips left a comment

IanPhilips commented Aug 2, 2022

Notify mentioned users on market publish #683

Notify mentioned users on market publish #683

Conversation

sipec commented Jul 22, 2022 • edited

vercel bot commented Jul 22, 2022 • edited

IanPhilips Jul 22, 2022

Choose a reason for hiding this comment

IanPhilips Jul 22, 2022

Choose a reason for hiding this comment

IanPhilips Jul 22, 2022

Choose a reason for hiding this comment

IanPhilips Jul 22, 2022

Choose a reason for hiding this comment

IanPhilips Jul 22, 2022

Choose a reason for hiding this comment

IanPhilips left a comment

Choose a reason for hiding this comment

IanPhilips commented Aug 2, 2022

sipec commented Jul 22, 2022 •

edited

vercel bot commented Jul 22, 2022 •

edited