pvr: stick the table creation in a transaction, and don't try to cont…

…inue when the tables couldn't be created
manio · Apr 1, 2012 · b3e96b3 · b3e96b3
1 parent 94ece28
commit b3e96b3
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/xbmc/pvr/PVRDatabase.cpp b/xbmc/pvr/PVRDatabase.cpp
@@ -48,6 +48,7 @@ bool CPVRDatabase::CreateTables()
     if (!CDatabase::CreateTables())
       return false;
 
+    BeginTransaction();
     CLog::Log(LOGINFO, "PVR - %s - creating tables", __FUNCTION__);
 
     CLog::Log(LOGDEBUG, "PVR - %s - creating table 'clients'", __FUNCTION__);
@@ -153,25 +154,30 @@ bool CPVRDatabase::CreateTables()
         ")"
     );
 
+    CommitTransaction();
     bReturn = true;
   }
   catch (...)
   {
     CLog::Log(LOGERROR, "PVR - %s - unable to create PVR database tables (error %i)", __FUNCTION__, (int)GetLastError());
+    RollbackTransaction();
     bReturn = false;
   }
 
-  // disable all PVR add-on when started the first time
-  ADDON::VECADDONS addons;
-  if ((bReturn = CAddonMgr::Get().GetAddons(ADDON_PVRDLL, addons, true, false)) == false)
-    CLog::Log(LOGERROR, "PVR - %s - failed to get add-ons from the add-on manager", __FUNCTION__);
-  else
+  if (bReturn)
   {
-    CAddonDatabase database;
-    database.Open();
-    for (IVECADDONS it = addons.begin(); it != addons.end(); it++)
-      database.DisableAddon(it->get()->ID());
-    database.Close();
+    // disable all PVR add-on when started the first time
+    ADDON::VECADDONS addons;
+    if ((bReturn = CAddonMgr::Get().GetAddons(ADDON_PVRDLL, addons, true, false)) == false)
+      CLog::Log(LOGERROR, "PVR - %s - failed to get add-ons from the add-on manager", __FUNCTION__);
+    else
+    {
+      CAddonDatabase database;
+      database.Open();
+      for (IVECADDONS it = addons.begin(); it != addons.end(); it++)
+        database.DisableAddon(it->get()->ID());
+      database.Close();
+    }
   }
 
   return bReturn;