[YUNIKORN-697]: Enforce partition name uniqueness in core (apache#321)

pkg/common/configs/config_test.go

@@ -413,12 +413,40 @@ partitions:
     queues:
       - name: root
   - name: default
+    queues:
+      - name: root
+  - name: part1
+    queues:
+      - name: root
 `
 	// validate the config and check after the update
 	conf, err = CreateConfig(data)
+	assert.Error(t, err, "duplicate partition name found with name default")
 	if err == nil {
 		t.Errorf("multiple default partitions parsing should have failed: %v", conf)
 	}
+
+	data = `
+partitions:
+  - name: default
+    queues:
+      - name: root
+  - name: part1
+    queues:
+      - name: root
+  - name: part1
+    queues:
+      - name: root
+  - name: part2
+    queues:
+      - name: root
+`
+	// validate the config and check after the update
+	conf, err = CreateConfig(data)
+	assert.Error(t, err, "duplicate partition name found with name part1")
+	if err == nil {
+		t.Errorf("duplicate partitions parsing should have failed: %v", conf)
+	}
 }
 
 func TestParseQueue(t *testing.T) {

pkg/common/configs/configvalidator.go

@@ -372,16 +372,16 @@ func Validate(newConfig *SchedulerConfig) error {
 		return fmt.Errorf("scheduler config is not set")
 	}
 
-	// check for the default partition, if the partion is unnamed set it to default
-	var defaultPartition bool
+	// check uniqueness
+	partitionMap := make(map[string]bool)
 	for i, partition := range newConfig.Partitions {
 		if partition.Name == "" || strings.ToLower(partition.Name) == DefaultPartition {
-			if defaultPartition {
-				return fmt.Errorf("multiple default partitions defined")
-			}
-			defaultPartition = true
 			partition.Name = DefaultPartition
 		}
+		if partitionMap[strings.ToLower(partition.Name)] {
+			return fmt.Errorf("duplicate partition name found with name %s", partition.Name)
+		}
+		partitionMap[strings.ToLower(partition.Name)] = true
 		// check the queue structure
 		err := checkQueuesStructure(&partition)
 		if err != nil {