-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default config should include host
from the current rustc
#65
Comments
I've been wondering about that. |
Would the change in #66 have any effect elsewhere? |
I suppose someone could try running the change (#66) on the crates that depend on compiletest: https://crates.io/crates/compiletest_rs/reverse_dependencies --- something like a mini crater run. (cc @shepmaster, who I think at one point was wondering whether automation for such testing might be useful.) I think the main things we should worry about are causing tests to fail silently and causing tests to be unexpectedly ignored. It seems unlikely to me that this change would result in either. Meanwhile, compiletest's current behavior is causing tests to be unexpectedly ignored right now out in the wild, as the miri code linked above shows. |
c.f. #13, where the Why would the default have the |
Miri's run-pass tests use a compiletest default config without setting the
host
field. My expectation is that this would result inhost
andtarget
being detected from the current version of rustc. Instead,host
gets set to "(none)", which causes a test that hasignore-cross-compile
to get unexpectedly ignored.The text was updated successfully, but these errors were encountered: