Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default config should include host from the current rustc #65

Closed
dwrensha opened this issue May 31, 2017 · 7 comments
Closed

default config should include host from the current rustc #65

dwrensha opened this issue May 31, 2017 · 7 comments

Comments

@dwrensha
Copy link
Contributor

Miri's run-pass tests use a compiletest default config without setting the host field. My expectation is that this would result in host and target being detected from the current version of rustc. Instead, host gets set to "(none)", which causes a test that has ignore-cross-compile to get unexpectedly ignored.

@dwrensha
Copy link
Contributor Author

(cc @oli-obk @eddyb)

@oli-obk
Copy link
Contributor

oli-obk commented May 31, 2017

I've been wondering about that.

@laumann
Copy link
Collaborator

laumann commented Jun 1, 2017

Would the change in #66 have any effect elsewhere?

@dwrensha
Copy link
Contributor Author

I suppose someone could try running the change (#66) on the crates that depend on compiletest: https://crates.io/crates/compiletest_rs/reverse_dependencies --- something like a mini crater run. (cc @shepmaster, who I think at one point was wondering whether automation for such testing might be useful.)

I think the main things we should worry about are causing tests to fail silently and causing tests to be unexpectedly ignored. It seems unlikely to me that this change would result in either. Meanwhile, compiletest's current behavior is causing tests to be unexpectedly ignored right now out in the wild, as the miri code linked above shows.

@dwrensha
Copy link
Contributor Author

c.f. #13, where the target field default behavior was added.

Why would the default have the target set from rustc, but have a "(none)" value in host?

@laumann
Copy link
Collaborator

laumann commented Jun 19, 2017

I see your point wrt #13 - I'll merge #66

@laumann
Copy link
Collaborator

laumann commented Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants