-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text for Ask-HN above comments #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olor actually uses the reference
I just realized there's a bug on the CommentsActivity in that if there are no comments then "Loading" will show forever. I'll fix this within the next couple of days. |
…ing view on the comments page
@wting, your thoughts on this design would be appreciated given that you requested the feature. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is at least part of what is requested in #6. This PR also adds some nice things like a loading view which can be easily added to any list as an empty view so that "loading" is displayed instead of a blank screen.
Screenshots:
Loading screen on the comments page: http://tinypic.com/r/2hqfog3/5
Some text with links: http://tinypic.com/r/517gom/5
Bottom margin: http://tinypic.com/r/2wmhvmv/5
Comment that doesn't take up the whole screen: http://tinypic.com/r/2ll0o5d/5
Loading panel on the comments page: http://tinypic.com/r/2hqfog3/5
Loading panel on the home screen: http://tinypic.com/r/n3uc6e/5