Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text for Ask-HN above comments #58

Merged
merged 13 commits into from
Oct 6, 2013
Merged

Add text for Ask-HN above comments #58

merged 13 commits into from
Oct 6, 2013

Conversation

maltzj
Copy link
Collaborator

@maltzj maltzj commented Sep 23, 2013

This is at least part of what is requested in #6. This PR also adds some nice things like a loading view which can be easily added to any list as an empty view so that "loading" is displayed instead of a blank screen.

Screenshots:
Loading screen on the comments page: http://tinypic.com/r/2hqfog3/5
Some text with links: http://tinypic.com/r/517gom/5
Bottom margin: http://tinypic.com/r/2wmhvmv/5
Comment that doesn't take up the whole screen: http://tinypic.com/r/2ll0o5d/5
Loading panel on the comments page: http://tinypic.com/r/2hqfog3/5
Loading panel on the home screen: http://tinypic.com/r/n3uc6e/5

@maltzj
Copy link
Collaborator Author

maltzj commented Sep 23, 2013

I just realized there's a bug on the CommentsActivity in that if there are no comments then "Loading" will show forever. I'll fix this within the next couple of days.

@maltzj
Copy link
Collaborator Author

maltzj commented Sep 24, 2013

@wting, your thoughts on this design would be appreciated given that you requested the feature.

@wting
Copy link

wting commented Sep 24, 2013

lg2m, sheeeeeep it!

             |    |    |
             )_)  )_)  )_)
            )___))___))___)\
           )____)____)_____)\\
         _____|____|____|____\\\__
---------\                   /---------
  ^^^^^ ^^^^^^^^^^^^^^^^^^^^^
    ^^^^      ^^^^     ^^^    ^^
         ^^^^      ^^^

@manmal manmal merged commit 26fa279 into manmal:master Oct 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants