Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still problems with processing of single timsTOF files #488

Closed
mschwoer opened this issue Aug 11, 2022 · 2 comments
Closed

Still problems with processing of single timsTOF files #488

mschwoer opened this issue Aug 11, 2022 · 2 comments

Comments

@mschwoer
Copy link
Contributor

Describe the bug
The error described in #434 still occurs on machines with > 60 cores, regardless of the n_processes settings.

@mschwoer
Copy link
Contributor Author

The root cause is that the n_processes settings are not propagated to score.py:train_RF(). Thus, the default value n_jobs: int = -1 is always used there, which makes GridSearchCV (according to doc) always use the maximum number of cores available. If this is bigger than 60, the crash described in #434 occurs.

Suggested solution:

  • pass n_processes settings to score.py:train_RF().
  • (optional) to make train_RF() itself robust against this issue, introduce another cpu core check (similar to the solution in 7e989bc)

straussmaximilian added a commit that referenced this issue Aug 11, 2022
#488: fix error when scoring on machines with more than 60 cpus
@straussmaximilian
Copy link
Member

Was closed with #489. Feel free to reopen in case anything else comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants