Add support for inherited tests #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from the feature request expressed by #278, add support for detecting inherited tests to the instrumentation runtime. This catches tests from both abstract classes and interfaces, mirroring the capabilities of JUnit Platform for unit tests.
The key to this change is to make
Class<*>.jupiterTestMethodsunderstand inherited methods, too. In contrast to the linked proposal, this will also correctly mark any inherited test as ignored on unsupported devices – therefore, the change should be made to the method, not the runner.Verified by adding a bunch of instrumentation tests to
:coreand some new unit tests to:runner.