-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed compile failure for missing 'CC' key #226
Conversation
@lgarrison While fixing this, I noticed that the offending line Should we honour the environment variable in |
Hmm... maybe we're better off ignoring CC in the environment, as it might be ancient, as you've said before. On the flip side, I just checked all the systems I regularly use, and none of them have CC defined. So maybe we shouldn't be worried about this and respect the environment variable? |
May be modern OS's don't define CC and therefore there is nothing to worry. But that could also mean that the older OS'es define CC to point to older compilers... I am leaning towards ignoring |
Yes, that's fine with me!
…On Fri, Jul 17, 2020 at 8:39 PM Manodeep Sinha ***@***.***> wrote:
May be modern OS's don't define CC and therefore there is nothing to
worry. But that could also mean that the older OS'es define CC to point to
older compilers...
I am leaning towards ignoring CC and removing that line from setup.py -
is that fine?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#226 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLA7S4ATKOS2QGOQVF2RXDR4DVKJANCNFSM4OXDE6ZQ>
.
--
Lehman Garrison <lgarrison@flatironinstitute.org>
Flatiron Research Fellow, Cosmology X Data Science Group
Center for Computational Astrophysics, Flatiron Institute
lgarrison.github.io
|
@lgarrison I am done with this PR - will you please take a look? If you are satisfied, then I will merge this in and release 2.3.4 |
Removed misleading comment that environment 'CC' was honoured
Fix for #225