Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It works great, but clients need change the font color #45

Closed
orchie opened this issue Oct 12, 2021 · 3 comments
Closed

It works great, but clients need change the font color #45

orchie opened this issue Oct 12, 2021 · 3 comments

Comments

@orchie
Copy link

orchie commented Oct 12, 2021

oh my god...
I saw this #3
but the tiptap https://github.com/ueberdosis/tiptap
alread has font color
ueberdosis/tiptap#1362
can you add it?
thanks

@manogi
Copy link
Owner

manogi commented Oct 12, 2021

@orchie - I might add it at a later point. It requires deciding on some kind of a color picker if I want to keep this feature up to par with the rest of the package. Also some thought into maybe adding the ability to preselect a color palette in the Nova resource, or something similar, so this is not trivial. But I might except a PR, if you want to have a go at it.

@orchie
Copy link
Author

orchie commented Oct 12, 2021

@manogi thanks!
can you give me some document about how to extend acustom button?
the color picker I think use <input type="color" > enough.
I will try to make it out.

@manogi
Copy link
Owner

manogi commented Oct 17, 2021

@orchie sorry, but you will have to look at the code - I have no time to write docs how to contribute to this package. But please, before you start writing a PR: keep in mind that I might not accept the PR for one reason or another, so if you don't want to take the risk of spending time on this for nothing, you probably better should think twice.

A different solution would be to fork the repo and use your own solution for a while and come back to this place from time to time to see when I have implemented a font color picker. Then you could revert to this original repo in your app.

@manogi manogi closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants