Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Detail Field anymore in 2.0 #50

Closed
mstaack opened this issue Jan 12, 2022 · 5 comments
Closed

No Detail Field anymore in 2.0 #50

mstaack opened this issue Jan 12, 2022 · 5 comments

Comments

@mstaack
Copy link

mstaack commented Jan 12, 2022

Is there any reason to have an empty detail field in 2.0?

With 1.0 all worked fine on my side :)

https://github.com/manogi/nova-tiptap/blob/v2.7.0/resources/js/components/DetailField.vue

isn't adding v1 vue component enough?

@mstaack mstaack changed the title No DetailField Anymore in 2.0 No DetailField anymore in 2.0 Jan 12, 2022
@mstaack mstaack changed the title No DetailField anymore in 2.0 No Detail Field anymore in 2.0 Jan 12, 2022
@jolora
Copy link

jolora commented Feb 1, 2022

Yes to me this seems like it must be a bug... I was surprised to find my TipTap fields missing on the detail view.

Edit: @manogi first of all, thanks for sharing your work! Was it intentional to remove the detail view? If so, why? For my implementation it's essential.

Edit2:: As a workaround I've just added duplicate Text fields like this:

Tiptap::make('Description'),
Text::make('Description')->asHTML()->onlyOnDetail(),

Suits me fine.

@manogi
Copy link
Owner

manogi commented Feb 1, 2022

Hi there - the detail field now behaves the same as the Trix detail field: it shows a "Show content" button to expand the content. Also like the Trix fied using the ->alwaysShow() method in the resource makes the content always visible in the detail view.

@manogi
Copy link
Owner

manogi commented Feb 1, 2022

P.S. added in v2.7.1

@jolora
Copy link

jolora commented Feb 1, 2022

Brilliant, thanks @manogi . I was on v2.7.0 ... v2.7.1 works a treat!

@manogi manogi closed this as completed Feb 1, 2022
@mstaack
Copy link
Author

mstaack commented Feb 2, 2022

brilliant stuff, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants