Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE #238

Merged
merged 2 commits into from Jun 27, 2018
Merged

Add LICENSE #238

merged 2 commits into from Jun 27, 2018

Conversation

korigod
Copy link
Contributor

@korigod korigod commented Jun 27, 2018

As stated at the project website and the package page, holopy is licensed under GPLv3. However, no LICENSE file was created, and it makes license choice unclear. I propose to add the license file because it's automatically recognized by github and then the license is shown in the usual place (near the contributors count). The COPYING file can be removed or not.

The project is licensed under GPLv3.
@barkls
Copy link
Contributor

barkls commented Jun 27, 2018

Hi korigod,
Thanks for the PR. As you noticed, the file COPYING contains part of the GPLv3 license. I'm not sure why the decision was made to include this rather than a full license file. Any insight @vnmanoharan or @tdimiduk?

@vnmanoharan
Copy link
Contributor

The COPYING file does contain the GPL v3, but for some reason the terms and conditions got truncated, and we didn't notice it. The truncation was not intentional (and is not binding, since the GPL v3 license itself cannot be modified). I would proposed doing as @korigod suggests and replacing the COPYING file with the LICENSE file. We'll need to augment this PR to delete the COPYING file. Thanks, @korigod, for catching this and filing the PR.

COPYING file has been replaced with LICENSE file with full GPL license.
@korigod
Copy link
Contributor Author

korigod commented Jun 27, 2018

@barkls, @vnmanoharan, thanks for the fast replies!

We'll need to augment this PR to delete the COPYING file.

Done.

@barkls barkls merged commit 1040edb into manoharan-lab:master Jun 27, 2018
barkls added a commit to barkls/holopy that referenced this pull request Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants