Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.7.0 #134

Merged
merged 9 commits into from Oct 27, 2016
Merged

Prepare 1.7.0 #134

merged 9 commits into from Oct 27, 2016

Conversation

manolo
Copy link
Owner

@manolo manolo commented Oct 20, 2016

Fixes #133


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2016

CLA assistant check
All committers have signed the CLA.

@manolo manolo force-pushed the prepare-1.7.0 branch 3 times, most recently from ce3bdef to c7161fb Compare October 20, 2016 15:39
@tomivirkki
Copy link
Contributor

package.json, line 11 at r3 (raw file):

  },
  "scripts": {
    "postinstall":"node node_modules/gwt-api-generator/bin/gwt-api-generator.js --package=paper-elements,iron-elements,app-elements,platinum-elements,vaadin-core-elements#master,vaadin-context-menu#master,vaadin-split-layout#master,manolo/vaadin-mock-xhr,manolo/vaadin-pouchdb#master --artifactId=vaadin-gwt-polymer-elements --groupId=com.vaadin.polymer --pom && mvn clean install javadoc:jar"

Talked about this listing with @jouni and came up with the following:

  • Perhaps instead of using the version that happens to be master at build-time, we should use fixed releases. This would require the (already drafted and should be good to go) 1.2.0 release of vaadin-core-elements
  • manolo/vaadin-mock-xhr and manolo/vaadin-pouchdb are probably included by accident?

Comments from Reviewable

@manolo
Copy link
Owner Author

manolo commented Oct 24, 2016

Review status: 0 of 27 files reviewed at latest revision, 1 unresolved discussion.


package.json, line 11 at r3 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

Talked about this listing with @jouni and came up with the following:

  • Perhaps instead of using the version that happens to be master at build-time, we should use fixed releases. This would require the (already drafted and should be good to go) 1.2.0 release of vaadin-core-elements
  • manolo/vaadin-mock-xhr and manolo/vaadin-pouchdb are probably included by accident?
- yes, we should release 1.2.0 before this? also I need a way to include the two components that seems not be in 1.2.0 (split, context) - yes, I forgot to remove them, I use those in my tests projects, actually the demo project uses the mock but it should not be included in this bundle.

Comments from Reviewable

@manolo
Copy link
Owner Author

manolo commented Oct 25, 2016

Review status: 0 of 27 files reviewed at latest revision, 1 unresolved discussion.


package.json, line 11 at r3 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

  • yes, we should release 1.2.0 before this? also I need a way to include the two components that seems not be in 1.2.0 (split, context)
  • yes, I forgot to remove them, I use those in my tests projects, actually the demo project uses the mock but it should not be included in this bundle.
1.- Removed all master references, so as this depends on latest releases. 2.- done

Comments from Reviewable

@tomivirkki
Copy link
Contributor

package.json, line 11 at r3 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

1.- Removed all master references, so as this depends on latest releases.
2.- done

Now that vaadin-core-elements 1.2 is out, we should depend on that here.

Comments from Reviewable

@manolo
Copy link
Owner Author

manolo commented Oct 26, 2016

Review status: 0 of 27 files reviewed at latest revision, 1 unresolved discussion.


package.json, line 11 at r3 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

Now that vaadin-core-elements 1.2 is out, we should depend on that here.

We don't depend on any specific version for this, it should work with latest stable versions, like iron, paper, etc.

Comments from Reviewable

Demo is using vaadin-mock-xhr which is not part of the
gwt-polymer-elements.jar.
This commit also helps to users depending on other
components how to setup de maven project.
@tomivirkki
Copy link
Contributor

Reviewed 2 of 4 files at r1, 23 of 25 files at r3, 5 of 5 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants