Fixes issue #38 - Fix code smells (#39)

manorrock · Mar 25, 2023 · f91c741 · f91c741
1 parent 01f2f08
commit f91c741
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/...on/src/main/java/com/manorrock/oyena/lifecycle/action/DefaultActionParameterProducer.java b/...on/src/main/java/com/manorrock/oyena/lifecycle/action/DefaultActionParameterProducer.java
@@ -125,8 +125,8 @@ private ActionQueryParameter getActionQueryParameterAnnotation(Annotation[] anno
         ActionQueryParameter result = null;
         if (annotations != null && annotations.length > 0) {
             for (Annotation annotation : annotations) {
-                if (annotation instanceof ActionQueryParameter) {
-                    result = (ActionQueryParameter) annotation;
+                if (annotation instanceof ActionQueryParameter actionQueryParameter) {
+                    result = actionQueryParameter;
                     break;
                 }
             }

diff --git a/...tion/src/main/java/com/manorrock/oyena/lifecycle/action/DefaultActionResponseHandler.java b/...tion/src/main/java/com/manorrock/oyena/lifecycle/action/DefaultActionResponseHandler.java
@@ -50,9 +50,9 @@ public class DefaultActionResponseHandler implements ActionResponseHandler {
      * Get the default lifecycle.
      *
      * <p>
-     * FIXME - This method lazily gets the default lifecycle as FactoryFinder is
-     * not properly re-entrant. We should be able to initialize the
-     * defaultLifecycle variable in the constructor of this class. See
+     * NOTE - This method lazily gets the default lifecycle as FactoryFinder is
+     * not properly re-entrant (as of 20230324). We should be able to initialize
+     * the defaultLifecycle variable in the constructor of this class. See
      * https://github.com/eclipse-ee4j/mojarra/issues/4379
      * </p>
      *

diff --git a/lifecycle/cdi/src/main/java/com/manorrock/oyena/lifecycle/cdi/CdiLifecycleFactory.java b/lifecycle/cdi/src/main/java/com/manorrock/oyena/lifecycle/cdi/CdiLifecycleFactory.java
@@ -95,12 +95,14 @@ public BeanManager getBeanManager() {
             InitialContext initialContext = new InitialContext();
             beanManager = (BeanManager) initialContext.lookup("java:comp/BeanManager");
         } catch (NamingException ne) {
+            // swallowing this on purpose.
         }
         if (beanManager == null) {
             try {
                 InitialContext initialContext = new InitialContext();
                 beanManager = (BeanManager) initialContext.lookup("java:comp/env/BeanManager");
             } catch (NamingException ne) {
+                // swallowing this on purpose.
             }
         }
         return beanManager;

diff --git a/lifecycle/rest/src/main/java/com/manorrock/oyena/lifecycle/rest/RestMappingMatch.java b/lifecycle/rest/src/main/java/com/manorrock/oyena/lifecycle/rest/RestMappingMatch.java
@@ -39,7 +39,7 @@ public class RestMappingMatch {
     /**
      * Stores the bean.
      */
-    private Bean<? extends Object> bean;
+    private Bean bean;
 
     /**
      * Stores the method.
@@ -61,7 +61,7 @@ public class RestMappingMatch {
      *
      * @return the bean.
      */
-    public Bean<? extends Object> getBean() {
+    public Bean getBean() {
         return bean;
     }
 
@@ -106,7 +106,7 @@ public String getRestPath() {
      *
      * @param bean the bean.
      */
-    public void setBean(Bean<? extends Object> bean) {
+    public void setBean(Bean bean) {
         this.bean = bean;
     }