Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual formatting tweaks #1

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

Azquelt
Copy link

@Azquelt Azquelt commented Dec 12, 2023

This PR makes the following additional formatting tweaks after the auto format plugin was added:

  • Allow the closing parenthesis of a method invocation to be on the following line
    • Revert changes to SecurityActions classes where the original formatting is now permitted
  • Manually break lines in the InjectionTargetFactory example for readability
  • Fix the example code in InterceptionFactory
    • Also allows the formatter to format it properly
  • Manually reflow some paragraphs throughout the Javadoc

You're welcome to drop or squash any of these changes as you see fit.

Break the lines in the InjectionTargetFactory example more
intelligently.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Correct the constructor name in the example, which also causes the
formatter to format it correctly.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Allow (but don't require) the closing parenthesis of a method invocation
to be on the following line.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
The autoformat settings will not join lines together which has resulted
in some cases where the line lengths are very uneven because the
formatter has needed to break a line which was slightly too long.

Reflow these paragraphs manually.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Copy link
Owner

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Azquelt!

@manovotn manovotn merged commit 04bee17 into manovotn:formattingRules Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants