Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing or changing subjective rules #95

Closed
manovotny opened this issue Apr 13, 2018 · 1 comment
Closed

Consider removing or changing subjective rules #95

manovotny opened this issue Apr 13, 2018 · 1 comment

Comments

@manovotny
Copy link
Owner

manovotny commented Apr 13, 2018

Let's take max-statements, for example... Say it's set to 10 lines. I then write this function that is 11 lines. Maybe it should be broken up into smaller, more easily consumable functions. Maybe the code makes more sense to stay together because it eloquently encapsulates a piece of functionality well. And that's the problem...

It depends.

Subjective rules like this are usually better left disabled and the kinds of things they try to prevent are better left to code reviews and conversations than hard and fast, black and white rules that arbitrarily force you to change the code or add a disable comment.

The following rules are in eslint-config-get-off-my-lawn and should be considered for removal, or at the very least, changed to a warning.

  • complexity
  • max-depth
  • max-nested-callbacks
  • max-params
  • react/no-set-state
manovotny added a commit that referenced this issue Apr 12, 2019
@manovotny
Copy link
Owner Author

Fixed in #105.

@manovotny manovotny mentioned this issue Apr 18, 2019
Merged
manovotny added a commit that referenced this issue Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant