You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let's take max-statements, for example... Say it's set to 10 lines. I then write this function that is 11 lines. Maybe it should be broken up into smaller, more easily consumable functions. Maybe the code makes more sense to stay together because it eloquently encapsulates a piece of functionality well. And that's the problem...
It depends.
Subjective rules like this are usually better left disabled and the kinds of things they try to prevent are better left to code reviews and conversations than hard and fast, black and white rules that arbitrarily force you to change the code or add a disable comment.
The following rules are in eslint-config-get-off-my-lawn and should be considered for removal, or at the very least, changed to a warning.
complexity
max-depth
max-nested-callbacks
max-params
react/no-set-state
The text was updated successfully, but these errors were encountered:
Let's take
max-statements
, for example... Say it's set to 10 lines. I then write this function that is 11 lines. Maybe it should be broken up into smaller, more easily consumable functions. Maybe the code makes more sense to stay together because it eloquently encapsulates a piece of functionality well. And that's the problem...It depends.
Subjective rules like this are usually better left disabled and the kinds of things they try to prevent are better left to code reviews and conversations than hard and fast, black and white rules that arbitrarily force you to change the code or add a disable comment.
The following rules are in
eslint-config-get-off-my-lawn
and should be considered for removal, or at the very least, changed to a warning.complexity
max-depth
max-nested-callbacks
max-params
react/no-set-state
The text was updated successfully, but these errors were encountered: