Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square root #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Square root #42

wants to merge 2 commits into from

Conversation

hpbyte
Copy link

@hpbyte hpbyte commented Oct 16, 2018

Description of new feature, or changes

It will return the square root of the given number by using Newton's Method

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

#10

People to notify

@manrajgrover manrajgrover self-requested a review October 16, 2018 17:03
* @return {Number} square root of the given number
*/

const sqaureRoot = (num) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function name typo?

* Show fibonacci sequence up to a given number
* @param {Number} num given number
*/
const fibonacci = (num) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better if it was the nth number instead of up until a certain number value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants