Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in interpolationSearch to allow duplicates in input array #88

Merged

Conversation

umairnadeem
Copy link
Contributor

Description of new feature, or changes

Add extra test to check for edge-case of array containing all similar values in interpolationSearch algorithm input, and fix the bug to allow the test to pass.

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

Fixes #87

People to notify

@manrajgrover

@umairnadeem umairnadeem changed the title BUG FIX: Fix bug in interpolationSearch to allow duplicates in input array Fix bug in interpolationSearch to allow duplicates in input array Jul 4, 2019
Copy link
Collaborator

@remes2000 remes2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@remes2000 remes2000 merged commit cec55a3 into manrajgrover:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interpolationSearch always returns -1 for array with duplicates
2 participants