Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Issue #47} Synchronous spinner #132

Closed
wants to merge 9 commits into from

Conversation

foster999
Copy link

@foster999 foster999 commented Oct 13, 2019

Description of new feature, or changes

Added the ability to manually render single spinner steps, via:

  • 'manual_step' argument when creating Halo class instance
  • '.step()' method to trigger single frame to render
  • 'test_manual_step' test

Usage

with Halo(spinner='dots', manual_step=True) as spinner:
    for text in ["foo","bar"]*5:
        spinner.text = 'Loading {}'.format(text)
        spinner.step()
        do_something(text)

or

spinner = Halo(spinner="dots", manual_step=True)
spinner.start()
for text in ["foo", "bar"]*5:
    spinner.text=text
    spinner.step()
    do_something(text)
spinner.stop()

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

Fixes #47 (new feature)

People to notify

@steelman

@coveralls
Copy link

coveralls commented Oct 13, 2019

Pull Request Test Coverage Report for Build 420

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.01%) to 90.008%

Totals Coverage Status
Change from base Build 409: -1.01%
Covered Lines: 949
Relevant Lines: 1035

💛 - Coveralls

@foster999 foster999 marked this pull request as ready for review October 13, 2019 21:57
@manrajgrover manrajgrover self-requested a review October 21, 2019 03:02
@foster999 foster999 mentioned this pull request Sep 5, 2020
@foster999 foster999 closed this Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronous spinner
2 participants